Repository navigation
feat(vscode): add OIDC-compatible publish-release-vsix composite action - W-24756661 - #207
Merged
Merged
Conversation
2 tasks
madhur310
added a commit
to forcedotcom/salesforcedx-vscode
that referenced
this pull request
Nov 10, 2026
… W-24756661 The inlined download+publish+retry logic validated here has been extracted to salesforcecli/github-workflows's vscode/publish-release-vsix composite action (salesforcecli/github-workflows#207), since it runs as a step inside the caller's own job (keeping job_workflow_ref pointed at this repo) rather than as a separate job in a nested reusable workflow. Switches this test workflow to call that action, pinned to its PR branch until #207 merges, so the extracted shape gets the same end-to-end validation before anything real depends on it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
madhur310
marked this pull request as ready for review
November 10, 2026 21:53
mshanemc
approved these changes
Nov 12, 2026
This was referenced Nov 12, 2026
…on - W-24756661
vscode-publish-release-vsix.yml is a job-level reusable workflow, so vsce
publish --oidc inside it always exchanges against job_workflow_ref pointing
at this repo rather than the caller's -- confirmed via a live test in
forcedotcom/salesforcedx-vscode, where every --oidc attempt through that
nested workflow got a 401 ("token could not be exchanged for the specified
publisher") despite a Trusted Publishing policy registered for the caller's
own repo + workflow filename. A composite action runs as a step inside the
caller's own job instead, so job_workflow_ref matches what's registered.
Adds vscode/publish-release-vsix as the OIDC-safe equivalent of the existing
PAT-based reusable workflow, following the same pattern as the already
inline-called vscode/publish-vsix action.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
madhur310
force-pushed
the
ms/W-24756661-vsce-oidc-composite-action
branch
from
November 12, 2026 19:42
bc81f99 to
3584eaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/actions/vscode/publish-release-vsixas an OIDC-safe alternative tovscode-publish-release-vsix.ymlfor publishing to the VS Code Marketplace.vscode-publish-release-vsix.ymlis a job-level reusable workflow. Live-tested inforcedotcom/salesforcedx-vscode(see publishVSCodeMarketplaceTrusted.yml): everyvsce publish --oidccall made from inside that nested workflow got a401 Unauthorized("The token could not be exchanged for the specified publisher"), even with a Trusted Publishing policy registered for the caller's own repo + workflow filename. The Marketplace's OIDC trust check appears to key off the token'sjob_workflow_refclaim, which for a nested reusable workflow always points at this repo, not the caller's.job_workflow_refstays pointed at the caller. A follow-up live test using this same inlined shape against real Marketplace OIDC published all 17 extensions successfully with zero 401s.--oidcto the reusable workflow itself -- that approach can't work regardless of what changes inside the workflow, since the mismatch happens at theuses:job-delegation boundary before any of that code runs.Test plan
forcedotcom/salesforcedx-vscode(dry-run + real publish with--skip-duplicateagainst an already-published nightly tag) -- succeeded with no 401s.forcedotcom/salesforcedx-vscode's realpublishVSCode.yml(currently still PAT-based viavscode-publish-release-vsix.yml@main) once reviewed.🤖 Generated with Claude Code